This repository was archived by the owner on Apr 29, 2022. It is now read-only.
WIP list accepted talks/proposals#975
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
patrick91 approved these changes May 20, 2019
| deflist_accepted_talks_for_current_conference(request): | ||
| """ | ||
| """ | ||
| # Copy from conference/talk_vorting.py; |
Member
There was a problem hiding this comment.
Suggested change
| # Copy from conference/talk_vorting.py; | |
| # Copy from conference/talk_voting.py; |
umgelurgel suggested changes May 20, 2019
Contributor
umgelurgel left a comment
umgelurgel left a comment There was a problem hiding this comment.
Looks good - one small comment that would help keep the codebase cleaner - I can help apply the changes.
Also, since it's a new view - could we add some xfailed tests for it?
| """ | ||
| """ | ||
| # Copy from conference/talk_vorting.py; | ||
| # Possibly could be refactored to use some function to come up with filters |
Contributor
There was a problem hiding this comment.
Since we have the same code in two files, this is definitely a candidate to be refactored.
umgelurgel changed the title Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.