Skip to content

Conversation

@JuliaPoo
Copy link
Collaborator

@JuliaPooJuliaPoo commented Aug 9, 2023

Fix three bugs:

  1. There's a mis-port of PARTITIONNODE_OVERWRITE where the child_test is supposed to use dst and not *dst
  2. The call to PARTITIONNODE_OVERWRITE requires ctx, but the stack pointer isn't updated until after propagating through the entire instruction, causing PARTITIONNODE_OVERWRITE to operate on the wrong ctx
    • Fix is to mutate ctx's stackpointer
  3. COPY should use PARTITIONNODE_OVERWRITE rather than PARTITIONNODE_SET

In addition, there's some refactor on the debugging output.

@JuliaPooJuliaPoo changed the title Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRI…Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and typo in PARTITIONNODE_OVERWRITEAug 9, 2023
@JuliaPooJuliaPoo changed the title Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and typo in PARTITIONNODE_OVERWRITEFix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and mis-port of PARTITIONNODE_OVERWRITEAug 9, 2023
Copy link
Owner

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Fidget-SpinnerFidget-Spinner merged commit 6ecf3d2 into partition_algoAug 9, 2023
@Fidget-SpinnerFidget-Spinner deleted the partition_algo_jules branch August 9, 2023 19:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JuliaPoo@Fidget-Spinner