Add missing Admin access const value#1
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…meout fix(cli): make 'timeout', 'per_page' and 'page' type explicit
This reverts commit a349793. Co-authored-by: Wadim Klincov <[email protected]>
Create a new ArrayAttribute class. This is to indicate types which are sent to the GitLab server as arrays https://docs.gitlab.com/ee/api/#array At this stage it is identical to the CommaSeparatedListAttribute class but will be used later to support the array types sent to GitLab. This is the second step in a series of steps of our goal to add full support for the GitLab API data types[1]: * array * hash * array of hashes Step one was: commit 5127b15 [1] https://docs.gitlab.com/ee/api/#encoding-api-parameters-of-array-and-hash-types Related: python-gitlab#1698
…ays_2 chore: create new ArrayAttribute class
The usage of deleting was incorrect according to the current API. Remove custom `delete()` method as not needed. Add tests to show it works with labels needing to be encoded. Also enable the test_group_labels() test function. Previously it was disabled. Add ability to do a `get()` for group labels. Closes: python-gitlab#1867
…ete_label fix: remove custom `delete` method for labels
The non-keyword arguments were a tiny bit confusing as the destination was first and the source was second. Change the order and require key-word only arguments to ensure we don't silently break anyone.
…y_dict chore: require kwargs for `utils.copy_dict()`
Co-authored-by: Nejc Habjan <[email protected]>
docs: add transient errors retry info
There are occasions where a GitLab `list()` call does not return the `x-per-page` header. For example the listing of custom attributes. Update the type-hints to reflect that.
chore: correct type-hints for per_page attrbute
When pagination occurs python-gitlab uses the URL provided by the GitLab server to use for the next request. We had previously set the GitLab server configuraiton to say its URL was `http://gitlab.test` which is not in DNS. Set the hostname in the URL to `http://127.0.0.1:8080` which is the correct URL for the GitLab server to be accessed while doing functional tests. Closes: python-gitlab#1877
test(functional): fix GitLab configuration to support pagination
Create a custom `warnings.warn` wrapper that will walk the stack trace to find the first frame outside of the `gitlab/` path to print the warning against. This will make it easier for users to find where in their code the error is generated from
…tom_warn chore: create a custom `warnings.warn` wrapper
…int-2.x chore(deps): update dependency pylint to v2.13.7
…qa-pylint-2.x chore(deps): update pre-commit hook pycqa/pylint to v2.13.7
…ing-dependencies chore(deps): update typing dependencies
…est-7.x chore(deps): update dependency pytest to v7.1.2
…ing-dependencies chore(deps): update dependency types-requests to v2.27.21
…y-0.x chore(deps): update dependency mypy to v0.950
…ing-dependencies chore(deps): update dependency types-requests to v2.27.24
…ing-dependencies chore(deps): update dependency types-requests to v2.27.25
…o the upstream docs The actual documentation do not mention the locked state for a merge request
merge request can have state locked
The `build/` directory is created by the tox environment `twine-check`. When the `build/` directory exists `mypy` will have an error.
…rpreters Add the `cz` (`comittizen`) check by default. Set skip_missing_interpreters = True so that when a user runs tox and doesn't have a specific version of Python it doesn't mark it as an error.
…-env chore: add `cz` to default tox environment list and skip_missing_interpreters
…y-tox chore: exclude `build/` directory from mypy check
As shown here, Admin access is set to 60: https://docs.gitlab.com/ee/api/protected_branches.html#protected-branches-api
JohnVillalovosforce-pushed the add-admin-const branch from c3571b2 to d597506CompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown here, Admin access is set to 60:
https://docs.gitlab.com/ee/api/protected_branches.html#protected-branches-api