Skip to content

handling null, undefined, 0, empty string in method 'has()'#1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-kuharenko wants to merge 1 commit into
base:master
Choose a base branch
from
Open

handling null, undefined, 0, empty string in method 'has()' #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion JavaScript/1-object.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@ class Dictionary{
return this.map[key];
}
has(key){
return !!this.map[key];
return Object.keys(this.map)
Copy link

@Max-imMax-imFeb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please consider to use key in this.map

.includes(key);
}
delete(key){
delete this.map[key];
Expand Down