This repository was archived by the owner on Feb 2, 2024. It is now read-only.
VTune integration#814
Open
VTune integration #814
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Hardcode84 commented Apr 21, 2020
Native part is not included? |
vtune_integration.py Outdated
| ll.add_symbol('__itt_task_begin_new', itt.__itt_task_begin) | ||
| ll.add_symbol('__itt_task_end_new', itt.__itt_task_end) | ||
| defvtune_profiling_boxing(name_handle): |
Collaborator
There was a problem hiding this comment.
Why do we need this?
vtune_integration.py Outdated
| @@ -0,0 +1,40 @@ | |||
| importctypes | |||
Collaborator
There was a problem hiding this comment.
Let's rename file somehow. Probably, simlpy vtune.py
| handle=vt.ctypes_string_handle_create(b"Head\0") | ||
| functype_task_begin=ctypes.CFUNCTYPE(None, ctypes.c_void_p, ctypes.c_void_p) | ||
| ctypes_task_begin=functype_task_begin(itt.__itt_task_begin) |
Collaborator
There was a problem hiding this comment.
I believe it should be done in vtune.py, not here. And here just import these functions
added 2 commits April 22, 2020 19:16
| @sdc_overload_method(SeriesType, 'head') | ||
| @vtune_profiling_overload(name_handle="Series_head") |
Collaborator
There was a problem hiding this comment.
It should be part of sdc_overload_method decorator. We can extract type name and method name from where.
Collaborator
There was a problem hiding this comment.
You actually could call this decorator inside sdc_overload_method
Collaborator
AlexanderKalistratov commented Apr 22, 2020
Great progress actually! |
Contributor
PokhodenkoSA left a comment
PokhodenkoSA left a comment There was a problem hiding this comment.
Very old PR. It is better to close it.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.