Skip to content

Conversation

@akhilnarang
Copy link

Resolves#252

Comment on lines 191 to 197
kwargs={"input": input}

# Check if a timeout was specified and pass it along if so
ifself.timeout:
kwargs["timeout"] =self.timeout

stdout, stderr=result.communicate(**kwargs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kwargs={"input": input}
# Check if a timeout was specified and pass it along if so
ifself.timeout:
kwargs["timeout"] =self.timeout
stdout, stderr=result.communicate(**kwargs)
stdout, stderr=result.communicate(input=input, timeout=timeout)

This should work too?

Copy link
Author

@akhilnarangakhilnarangOct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep works, can't remember exactly why I had wanted to avoid passing a None value.
However the default value for timeout is None, so definitely makes sense to just do this.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request - support specifying timeout for pdf generation

2 participants

@akhilnarang@ankush