Skip to content

fix close(::Figure) and add test#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevengj merged 1 commit into from
Mar 11, 2023
Merged

fix close(::Figure) and add test #23

stevengj merged 1 commit into from
Mar 11, 2023

Conversation

@IanButterworth
Copy link
Contributor

@IanButterworthIanButterworth commented Mar 10, 2023

Fixes#22

stevengj
stevengj reviewed Mar 11, 2023
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023•
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@cc633dd). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## main #23 +/- ## ======================================= Coverage ? 17.14% ======================================= Files ? 5 Lines ? 449 Branches ? 0 ======================================= Hits ? 77 Misses ? 372 Partials ? 0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stevengjstevengj merged commit 7a29424 into JuliaPy:mainMar 11, 2023
@IanButterworthIanButterworth deleted the ib/close_fix branch March 11, 2023 02:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengjstevengjstevengj left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

close(::Figure) still broken

3 participants

@IanButterworth@codecov-commenter@stevengj