This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Fix bug: Namespace switch prevents LT from returning eval result#13
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ource file contains errors.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the source file contains errors, namespace switch will fail. Subsequent submission of eval(s) would need to wait for the msgloop to pick up the Exception, otherwise they will be considered to be from the same batch of erroneous submitted source.
This sleep() should not be repeated for each eval, unless the user switch the namespace. As such, I added the check to reduce the latency.