Fixed some Keccak testcases#67
Open
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 fixes:
It fixes a bug that was cause because an uninitialized variable
LastByteLeninstead of the argumentLastByteLengthwas used.I have reverted to
AddLastByteForCodeTest(lDataRow, #$13, 5);again, now the test cases do work.I still have no clue why #$13 represents the test vector 0b10011, but for some reason it works. Maybe some day someone will find out why it works :-)Edit 12 Feb 2025: Regarding point 2, I don't understand why I was confused back then.
0b10011 is 0x13 and Decimal 19. In Delphi hex numbers have a
$prefix, so both#$13and#19are correct, but not#$19.All test cases except the Unicode test case are working now. The Unicode test case might be impossible, though; see more details in #65