Skip to content

Conversation

@TerSent
Copy link

Summary

Improves type inference in async with pool.acquire() by:

  1. Adding -> connection.Connection return type to PoolAcquireContext.__aenter__
  2. Renaming internal attribute self.connection to self._conn to avoid confusion and help type checkers

Motivation

Without this change, type checkers (mypy, pyright, pylance) cannot correctly infer the type of the connection in:

asyncwithpool.acquire() asconn: awaitconn.fetchrow("SELECT 1") # ← conn has type 'Unknown' or 'Any'

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@TerSent