- Notifications
You must be signed in to change notification settings - Fork 437
Add support for password functions (useful for RDS IAM auth)#554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -204,6 +204,44 @@ async def test_auth_password_cleartext(self): | ||
| user='password_user', | ||
| password='wrongpassword') | ||
| async def test_auth_password_cleartext_callable(self): | ||
| def get_correctpassword(): | ||
| return 'correctpassword' | ||
| def get_wrongpassword(): | ||
| return 'wrongpassword' | ||
| conn = await self.connect( | ||
| user='password_user', | ||
| password=get_correctpassword) | ||
| await conn.close() | ||
| with self.assertRaisesRegex( | ||
| asyncpg.InvalidPasswordError, | ||
| 'password authentication failed for user "password_user"'): | ||
| await self._try_connect( | ||
| user='password_user', | ||
| password=get_wrongpassword) | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like flake8 is unhappy about the extra newline here | ||
| async def test_auth_password_cleartext_callable_coroutine(self): | ||
| async def get_correctpassword(): | ||
| return 'correctpassword' | ||
| async def get_wrongpassword(): | ||
| return 'wrongpassword' | ||
| conn = await self.connect( | ||
| user='password_user', | ||
| password=get_correctpassword) | ||
| await conn.close() | ||
| with self.assertRaisesRegex( | ||
| asyncpg.InvalidPasswordError, | ||
| 'password authentication failed for user "password_user"'): | ||
| await self._try_connect( | ||
| user='password_user', | ||
| password=get_wrongpassword) | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... and here | ||
| async def test_auth_password_md5(self): | ||
| conn = await self.connect( | ||
| user='md5_user', password='correctpassword') | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add support for coroutines (via
inspect.iscoroutinefunction()) to support async callbacks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, updated the branch with support for async password callbacks and an additional test for that case as well.