Skip to content

Conversation

@elprans
Copy link
Member

@elpranselprans commented Aug 16, 2020

asyncio.wait_for() currently has a bug where it raises a
CancelledError even when the wrapped awaitable has completed.
The upstream fix is in python/cpython#21894. This adds a workaround
until the aforementioned PR is merged, backported and released.

Co-authored-by: Adam Liddell [email protected]
Fixes: #467
Fixes: #547
Related: #468
Supersedes: #548

@elpranselprans requested a review from 1st1August 16, 2020 00:09
@elpranselpransforce-pushed the workaround-bpo37658 branch 2 times, most recently from 278c684 to 3f516c5CompareAugust 16, 2020 00:15
@yenbao1340
Copy link

Upstream's bug was fixed and merged (python/cpython#21894).
How can I apply this patch in my project?

`asyncio.wait_for()` currently has a bug where it raises a `CancelledError` even when the wrapped awaitable has completed. The upstream fix is in python/cpython#21894. This adds a workaround until the aforementioned PR is merged, backported and released. Co-authored-by: Adam Liddell <[email protected]> Fixes: #467Fixes: #547 Related: #468 Supersedes: #548
@elpranselpransforce-pushed the workaround-bpo37658 branch from 3f516c5 to 2bac166CompareAugust 27, 2020 16:53
@elpranselprans merged commit 2bac166 into masterAug 27, 2020
@aaliddell
Copy link
Contributor

Could this make it into a patch release, if a minor/major isn't planned any time soon?

@elprans
Copy link
MemberAuthor

Yeah, it's a good time to cut a release, since both Python 3.9 and PostgreSQL 13 have been released recently.

@elpranselprans deleted the workaround-bpo37658 branch October 23, 2020 16:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pool never closes if acquire with timeout is cancelled Leaked connections caused by timeout on pool.acquire

5 participants

@elprans@yenbao1340@aaliddell@1st1