Skip to content

Conversation

@elprans
Copy link
Member

While looking at #52, I noticed that httptools.__all__ is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52

@elpranselprans requested a review from 1st1February 9, 2020 01:44
@elpranselprans mentioned this pull request Feb 9, 2020
While looking at #52, I noticed that `httptools.__all__` is incorrect and doesn't actually include everything that is exported by the module, which might entice the users to import from the private submodule directly. Fixes: #52
@elpranselprans merged commit 9340d32 into masterFeb 29, 2020
@elpranselprans deleted the fix_dunder_all branch February 29, 2020 23:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API change from 0.0.13->0.1.1

3 participants

@elprans@1st1