Skip to content

Add 3.9 to the build a test matrix#62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fantix merged 10 commits into from
Mar 30, 2021
Merged

Add 3.9 to the build a test matrix #62

fantix merged 10 commits into from
Mar 30, 2021

Conversation

@b0g3r
Copy link
Contributor

@b0g3rb0g3r commented Mar 20, 2021•
edited
Loading

Related issue: #59

I also updated Cython, because setup.py failed on macOS 3.8.8

@b0g3r
Copy link
ContributorAuthor

b0g3r commented Mar 20, 2021

I temporarily move build_wheel into tests workflow for testing. Run: https://github.com/MagicStack/httptools/actions/runs/670486023

@b0g3r
Copy link
ContributorAuthor

b0g3r commented Mar 20, 2021

Hi, @elprans@1st1!

Thank you for such important and fast lib. I found that httptools doesn't have wheels for 3.9, so I add it to the build and test matrix. I also faced up a little problem on the 3.8.8 build, but it fixed when I bumped the Cython version to the latest minor update.

I was not sure that build_wheel will be running smoothly on 3.9, so I temporarily move it to tests workflow, and it worked great (logs). Could you please review it and create a new release with 3.9 wheels 🙏 ?

fantix
fantix approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@fantixfantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I'll get to the releases in a separate PR.

@fantixfantix merged commit e2d1a46 into MagicStack:masterMar 30, 2021
@cmachtcmacht mentioned this pull request Apr 9, 2021
Closed
@b0g3r
Copy link
ContributorAuthor

b0g3r commented Apr 18, 2021

@fantix could you please make a new release?

@fantixfantix mentioned this pull request Apr 23, 2021
Merged
fantix pushed a commit that referenced this pull request Apr 26, 2021
@b0g3r@fantix
Add 3.9 to the build a test matrix (#62)
f3ec736
* also updated the Cython version
@fantixfantix mentioned this pull request Apr 26, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantixfantixfantix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@b0g3r@fantix