Skip to content

Conversation

@fantix
Copy link
Member

I haven't touched the releasing part, but I've mimicked the part in test.yml based on how it is done in asyncpg.

Fixes#318
Fixes#354
Fixes#355
Fixes#361
Closes#368
Closes#371

@fantixfantix marked this pull request as ready for review December 7, 2020 03:32
@fantixfantix requested a review from elpransDecember 7, 2020 03:32
@elpranselprans requested a review from 1st1December 7, 2020 03:42
1st1
1st1 approved these changes Dec 7, 2020
Copy link
Member

@1st11st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work, Fantix. Huge thanks!

I'll leave it to @elprans to review the GitHub Actions part of this PR; the uvloop/tests fixes look good to me though.

Copy link
Member

@elpranselprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI part LGTM. Leaving the 3.9 compatibility bits for @1st1 to review. Thanks!

@1st11st1 merged commit 311997e into masterDec 7, 2020
@1st11st1 deleted the ci branch December 7, 2020 03:43
@fantix
Copy link
MemberAuthor

Thank you both for the lightning review! ⚡

@elpranselprans mentioned this pull request Dec 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants

@fantix@1st1@elprans@shadchin