Skip to content

Upgrade libuv to v1.46.0#571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fantix merged 2 commits into from
Oct 13, 2023
Merged

Upgrade libuv to v1.46.0 #571

fantix merged 2 commits into from
Oct 13, 2023

Conversation

@fantix
Copy link
Member

@fantixfantix commented Oct 10, 2023•
edited
Loading

(CPython code snippet of subprocess.py:)

if (_USE_POSIX_SPAWNandos.path.dirname(executable) andpreexec_fnisNoneandnotclose_fdsandnotpass_fdsandcwdisNoneand (p2cread==-1orp2cread>2) and (c2pwrite==-1orc2pwrite>2) and (errwrite==-1orerrwrite>2) andnotstart_new_sessionandprocess_group==-1andgidisNoneandgidsisNoneanduidisNoneandumask<0): self._posix_spawn(args, executable, env, restore_signals, p2cread, p2cwrite, c2pread, c2pwrite, errread, errwrite) return

@fantixfantix requested a review from 1st1October 10, 2023 03:09
@fantixfantix marked this pull request as draft October 10, 2023 04:18
@robd003robd003 mentioned this pull request Oct 10, 2023
Closed
@fantixfantix marked this pull request as ready for review October 11, 2023 23:29
1st1
1st1 reviewed Oct 12, 2023
View reviewed changes
uvloop/handles/process.pyx
# provide explicit API to choose such implementation detail.
# Based on current (libuv 1.46) behavior, setting
# UV_PROCESS_SETUID or UV_PROCESS_SETGID would reliably make
# libuv fallback to use fork, so let's just use it for now.
Copy link
Member

@1st11st1Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should make a PR to libuv to make it reliably configurable.

@fantixfantix merged commit 2e1978c into masterOct 13, 2023
@fantixfantix deleted the libuv-1.46 branch October 13, 2023 00:39
@fantixfantix mentioned this pull request Oct 13, 2023
Merged
fantix added a commit that referenced this pull request Oct 13, 2023
@fantix
uvloop 0.18.0
5ddf38b
Changes ======= * Port uvloop to Python 3.12 (#570) (by @1st1, @fantix in 9f82bd7 for #569) * Upgrade libuv to v1.46.0 (#571) (by @fantix in 2e1978c for #571) Fixes ===== * CI fixes (#520, #553) (by @altendky in 7783f1c, @dulmandakh in 1dd40f1) * Make extract_stack resilient to lacking frames. (#563) (by @jhance in 0687643 for #563)
This was referenced Oct 15, 2023
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fantix@1st1