- Notifications
You must be signed in to change notification settings - Fork 590
Test with Python 3.13#610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
edgarrmondragon commented Jul 5, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
edgarrmondragon commented Jul 5, 2024
I cherry-picked the patch from #604 |
edgarrmondragon commented Aug 15, 2024
Ok, so the build for 3.13 fails. Detailed errorThe 3.13 build for aiohttp is also failing. Detailed errorWhat's fun is the aiohttp CI uses uvloop (I don't know what for exactly), so I'm not sure who can first release 3.13 wheels 🙃. |
Dreamsorcerer commented Aug 18, 2024
Many of our tests run on uvloop, to ensure compatibility. Seems like we have a bit of a circular dependency here... |
Dreamsorcerer commented Aug 19, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Actually, we should automatically start building wheels with the next release even without tests passing. So, both our CIs should resolve over the next few weeks. |
fantix commented Aug 19, 2024
That's a good idea, Sam! I can push an alpha wheel of uvloop like 0.21a1 for Python 3.13 later this week |
edgarrmondragon commented Aug 19, 2024
Marking this as ready for review then :) |
Dreamsorcerer commented Aug 19, 2024
I think we have 3.13 wheels now with 3.10.5. |
fantix commented Aug 28, 2024
This is derived from python/cpython#111483 but available on all Python versions with uvloop, only that it's only enabled by default for Python 3.13 and above to be consistent with CPython behavior.
fantix commented Sep 3, 2024
uvloop 0.21.0b1 is up with 3.13 wheels. |
Changes ======= * Add cleanup_socket param on create_unix_server() (#623) (by @fantix in d6114d2) Fixes ===== * Use cythonized SO_REUSEPORT rather than the unwrapped native one. (#609) (by @ptribble in 4083a94 for #550) * UDP errors should result in protocol.error_received (#601) (by @jensbjorgensen in 3c3bbef) * Updates for Cython3 (#587) (by @alan-brooks in 3fba9fa for #587) * Test with Python 3.13 (#610) (by @edgarrmondragon in fb5a139)
Related: