Skip to content

ENH: checks to prevent infinite recursion#72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fbordignon wants to merge 1 commit into
base:main
Choose a base branch
from
Open

ENH: checks to prevent infinite recursion #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions src/PythonQtClassInfo.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,9 @@ PythonQtSlotInfo* PythonQtClassInfo::recursiveFindDecoratorSlotsFromDecoratorPro
{
inputInfo = findDecoratorSlotsFromDecoratorProvider(memberName, inputInfo, found, memberCache, upcastingOffset);
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
inputInfo = info._parent->recursiveFindDecoratorSlotsFromDecoratorProvider(memberName, inputInfo, found, memberCache, upcastingOffset+info._upcastingOffset);
if (this != info._parent){
inputInfo = info._parent->recursiveFindDecoratorSlotsFromDecoratorProvider(memberName, inputInfo, found, memberCache, upcastingOffset+info._upcastingOffset);
}
}
return inputInfo;
}
Expand DownExpand Up@@ -382,14 +384,18 @@ void PythonQtClassInfo::recursiveCollectDecoratorObjects(QList<QObject*>& decora
decoratorObjects.append(deco);
}
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
info._parent->recursiveCollectDecoratorObjects(decoratorObjects);
if (this != info._parent){
info._parent->recursiveCollectDecoratorObjects(decoratorObjects);
}
}
}

void PythonQtClassInfo::recursiveCollectClassInfos(QList<PythonQtClassInfo*>& classInfoObjects){
classInfoObjects.append(this);
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
info._parent->recursiveCollectClassInfos(classInfoObjects);
if (this != info._parent){
info._parent->recursiveCollectClassInfos(classInfoObjects);
}
}
}

Expand DownExpand Up@@ -584,7 +590,7 @@ bool PythonQtClassInfo::inherits(const char* name)
return true;
}
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
if (info._parent->inherits(name)){
if (info._parent != this && info._parent->inherits(name)){
return true;
}
}
Expand All@@ -597,7 +603,7 @@ bool PythonQtClassInfo::inherits(PythonQtClassInfo* classInfo)
return true;
}
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
if (info._parent->inherits(classInfo)){
if (info._parent != this && info._parent->inherits(classInfo)){
return true;
}
}
Expand DownExpand Up@@ -761,8 +767,11 @@ void* PythonQtClassInfo::recursiveCastDownIfPossible(void* ptr, const char** res
}
}
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
void* resultPtr = NULL;
if (!info._parent->isQObject()){
void* resultPtr = info._parent->recursiveCastDownIfPossible((char*)ptr + info._upcastingOffset, resultClassName);
if (this != info._parent){
resultPtr = info._parent->recursiveCastDownIfPossible((char*)ptr + info._upcastingOffset, resultClassName);
}
if (resultPtr){
return resultPtr;
}
Expand DownExpand Up@@ -870,7 +879,9 @@ void PythonQtClassInfo::createEnumWrappers(const QObject* decoratorProvider)
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
// trigger decorator() instead of createEnumWrappers(),
// which will then call createEnumWrappers().
info._parent->decorator();
if (info._parent != this){
info._parent->decorator();
}
}
}
}
Expand All@@ -889,7 +900,10 @@ PyObject* PythonQtClassInfo::findEnumWrapper(const char* name){
}
}
Q_FOREACH(const ParentClassInfo& info, _parentClasses){
PyObject* p = info._parent->findEnumWrapper(name);
PyObject* p = NULL;
if (info._parent != this){
p = info._parent->findEnumWrapper(name);
}
if (p) return p;
}
return NULL;
Expand DownExpand Up@@ -1004,6 +1018,10 @@ void PythonQtClassInfo::updateRefCountingCBs()
if (!_parentClasses.isEmpty()){
// we only search in single inheritance, using the first parent class
PythonQtClassInfo* parent = _parentClasses.at(0)._parent;
if (parent == this){
_searchRefCountCB = false;
return;
}
parent->updateRefCountingCBs();
// propagate to ourself
_refCallback = parent->_refCallback;
Expand Down