Angular 9,10 NSRouterLinkActive does not set CSS class

[denlysenko]

After upgrading Angular from 8 to 10, nsRouterLinkActive directive stopped adding CSS class on element. Seems like the reason is in this this.renderer.setStyle(should be this.renderer.addClass) call here

nativescript-angular/nativescript-angular/router/ns-router-link-active.ts

Line 107 in 51bd639

this.classes.forEach((c) => this.renderer.setStyle(this.element.nativeElement, c, isActiveLinks));

[NathanWalker]

Thanks @denlysenko we’ll get this updated and publish a patch this afternoon.

[NathanWalker]

@denlysenko published in 10.0.1 - let us know if you have further issue; thanks again for report.

[denlysenko]

@NathanWalker After your fix CSS class is being added, but it's added to the link, which is not active.
I guess you should swap removeClass and addClass in this if/else

nativescript-angular/nativescript-angular/router/ns-router-link-active.ts

Lines 108 to 112 in 23cf9dc

	if (isActiveLinks) {
	this.renderer.removeClass(this.element.nativeElement, c);
	} else {
	this.renderer.addClass(this.element.nativeElement, c);
	}

[NathanWalker]

Ah @denlysenko thanks, do you wanna try to submit a PR?

[denlysenko]

ok