Skip to content

Conversation

@ehlewis
Copy link
Contributor

No description provided.

@EkultekEkultek self-requested a review March 22, 2018 22:25
@Ekultek
Copy link
Contributor

@ehlewis
Copy link
ContributorAuthor

What're you suggesting to do? Im not too familiar in this area
This is just a one liner to start the postgresql service, not too sure why it needs to be done through brew but apparently it does on OSX

@Ekultek
Copy link
Contributor

Put the brew calls into bash scripts, that’s all you need to do. It has to be done through brew because macos doesn’t have apt/pacman/yum. Brew is the package manager for macos

Copy link
Contributor

@EkultekEkultek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the brew calls into bash scripts

@ehlewis
Copy link
ContributorAuthor

Fixed, didn't see those initially

@Ekultek
Copy link
Contributor

Ekultek commented Mar 23, 2018

Remove the sudo calls for the OS X runs. Brew can’t be run with sudo on Yosemite and higher

Nevermind didn't look at the code fully, merging

@EkultekEkultek merged commit ce02fb7 into NullArray:dev-betaMar 23, 2018
@ehlewisehlewis deleted the osx branch March 23, 2018 22:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ehlewis@Ekultek