Bug fix unicode hosts#105
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The try except block was overriding the path var with the contents of the folder causing errors further down. Changed to just check for proper opening of the file.
Contributor
ehlewis commented Mar 26, 2018
This needs to be requested to merge into dev-beta not master |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #104. Appears the problem arose when you tried to add multiple single hosts, exit the tool, start it up again, and then view. My own testing showed it was a reliable bug, not dependent on the IP used:
[+] loading gathered hosts from '['1.1.1.1\n', '1.1.1.2\n', '1.1.1.3\n']'
Traceback (most recent call last):
File "autosploit.py", line 5, in
main()
File "/root/Null-AutoSploit/autosploit/main.py", line 58, in main
terminal.terminal_main_display(loaded_exploits)
File "/root/Null-AutoSploit/lib/term/terminal.py", line 273, in terminal_main_display
self.view_gathered_hosts()
File "/root/Null-AutoSploit/lib/term/terminal.py", line 73, in view_gathered_hosts
with open(self.host_path) as hosts:
TypeError: coercing to Unicode: need string or buffer, list found
This pull request fixes the issue:
root@autosploit# 5
[+] loading gathered hosts from '/root/AutoSploit/hosts.txt'
[+] 1.1.1.1
[+] 1.1.1.2
[+] 1.1.1.3