Fixes some issues#673
Merged
Fixes some issues #673
+102 −70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Ekultek commented Apr 18, 2019
Ekultek commented - Have to have the right version to create an issue
- Changes the way that issue "identifiers" are created
- Some minor fixes
Docker refactor
… version it will not create an issue, also changes how the identifier is created
ContributorAuthor
Ekultek commented Apr 18, 2019
Also the docker stuff |
Owner
NullArray commented Apr 18, 2019
Thought i merged the docker stuff already? Anyway i'll add my review. |
Uh oh!
There was an error while loading. Please reload this page.
NullArray requested changes Apr 18, 2019
Owner
NullArray commented Apr 18, 2019
If i am missing something, please let me know. It could be an oversight on my part but i'd like to make sure before i merge it into the master branch. |
NullArray approved these changes Apr 18, 2019
Owner
NullArray left a comment
NullArray left a comment There was a problem hiding this comment.
Thank you for addressing the issue. Approved and merged.
ContributorAuthor
Ekultek commented Apr 18, 2019
<3 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.