small refactoring for lib/settings & add forgotten .format() to main.py#80
Uh oh!
There was an error while loading. Please reload this page.
Conversation
| importlib.output | ||
| importlib.banner | ||
| CUR_DIR="{}".format(os.getcwd()) |
There was a problem hiding this comment.
One variable, or ten more function calls.
There was a problem hiding this comment.
I mean it's not much different, but I see where you're coming from
| make the directory if it does not exist | ||
| """ | ||
| ifnotos.path.exists(dir): | ||
| os.mkdir(dir) |
There was a problem hiding this comment.
I think, two small lines will be better than one-time call of locally defined function (in case of optimization too).
There was a problem hiding this comment.
Okay I see what you did, change the variable to path so it doesn't overwrite the built in dir var
| globalstop_animation | ||
| i=0 | ||
| whilenotstop_animation: | ||
| """ |
There was a problem hiding this comment.
You realize that in order to stop the animation, I have to print a new line character otherwise it does an endless cycle
Ekultek left a comment
Ekultek left a comment There was a problem hiding this comment.
Change variable to path so it doesn't overwrite built in dir line 133
NullArray commented Mar 1, 2018
I'll merge this into dev-beta, and then add it to master as a quick hotfix. |
3 participants
No description provided.