Skip to content

Conversation

@YADROOKIE
Copy link

@mergeable
Copy link

mergeablebot commented Aug 29, 2022

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@YADROOKIEYADROOKIE marked this pull request as draft August 29, 2022 06:36
@webupwebup requested review from webup and removed request for benjaminhuoAugust 29, 2022 06:41
@webupwebup added the type: feature New feature or request label Aug 29, 2022
@YADROOKIEYADROOKIE marked this pull request as ready for review September 1, 2022 11:53
@YADROOKIEYADROOKIE marked this pull request as draft September 1, 2022 11:53
@webup
Copy link
Collaborator

webup commented Sep 2, 2022

LGTM, basically.

@YADROOKIE please help verify this feature via function and plugin bundle image over K8s as well, thanks.

@webupwebup marked this pull request as ready for review September 2, 2022 04:42
@benjaminhuo
Copy link
Member

Great efforts! Thanks, @YADROOKIE@webup Nodejs functions framework has become the most well-supported and active functions framework of OpenFunction!

@webupwebup changed the title Feature/skywalking plugin for tracingfeat: enable skywalking plugin for tracingSep 4, 2022
@webupwebup merged commit 32672fa into OpenFunction:masterSep 4, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: featureNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@YADROOKIE@webup@benjaminhuo