Skip to content

Build for Alpine arm64 and arm32#72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adityapatwardhan wants to merge 13 commits into
base:master
Choose a base branch
from
Open

Build for Alpine arm64 and arm32 #72

adityapatwardhan wants to merge 13 commits into from

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhanadityapatwardhan commented Aug 30, 2021

No description provided.

andyleejordan
andyleejordan approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@andyleejordanandyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@adityapatwardhanadityapatwardhan changed the title Build for Alpine arm64Build for Alpine arm64 and arm32Sep 1, 2021
andyleejordan
andyleejordan reviewed Sep 2, 2021
View reviewed changes
andyleejordan
andyleejordan requested changes Sep 2, 2021
View reviewed changes
Copy link
Member

@andyleejordanandyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some stuff 🤞

andyleejordan
andyleejordan approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@andyleejordanandyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do you want to squash and/or rebase the commits?

@adityapatwardhan
Copy link
MemberAuthor

adityapatwardhan commented Sep 7, 2021

Typically we squash.. I am testing that these bits actually work. Also seems the CI does not upload artifacts.. I will work on that now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordanandyleejordanandyleejordan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adityapatwardhan@andyleejordan