Update the Trusted_Platform_Assemblies list#83
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5 tasks
PaulHigin approved these changes Nov 22, 2022
| // NOTE: The names must not include the .dll extension because it will be added programmatically. | ||
| static PCSTR trustedAssemblies[] = | ||
| { | ||
| "getfilesiginforedistwrapper", |
MemberAuthor
There was a problem hiding this comment.
The new list is generated from the trace output of pwsh.exe (the min-size package, so WPF things are not included) by setting the environment variable COREHOST_TRACE beforehand.
For this specific one, I don't know where it's pulled from.
Contributor
iSazonov commented Nov 23, 2022
Maybe add new test in PowerShell repository? We will move to .Net 8 soon... |
5 tasks
adityapatwardhan approved these changes Dec 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the Trusted_Platform_Assemblies list to be in sync with the TPA list of
pwsh.exefrom the min-size build (no WPF related dependencies).PR Context
The TPA list were not updated for 7.3.0, which caused regression reported: PowerShell/PowerShell#18587