#4750 Fix Get-Date -UFormat %u behavior#14549

brianary · 2021-01-05T23:48:34Z

PR Summary

Corrects the behavior of %u in Get-Date -UFormat to match ISO 8601.

PR Context

This is to fix one of the format issues in #4750.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed: Document Request: Get-Date -UFormat %u ISO8601 standard (1-7) MicrosoftDocs/PowerShell-Docs#7180
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

ghost · 2021-01-05T23:57:54Z

All CLA requirements met.

brianary · 2021-01-06T02:28:51Z

I can't really access the details, but the test failures appear to be unrelated.

src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs

iSazonov · 2021-01-06T07:13:39Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Date.Tests.ps1

+ It "using -uformat 'u' produces the correct output" -TestCases @(
+ @{date="1998-01-02" dayOfWeek = "5"},
+ @{date="1998-01-03" dayOfWeek = "6"},
+ @{date="2003-01-03" dayOfWeek = "5"},
+ @{date="2004-01-02" dayOfWeek = "5"},


Please clarify how you select the test values (whole list)?

I just used the values from the previous test for %V, which is related, then added a couple recent dates that had led to discovering the bug. I'll add a comment to that effect, or else select some other dates.

ghost · 2021-01-14T02:00:06Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

brianary · 2021-01-15T02:27:09Z

Let me know if there's anything further I can provide.

iSazonov · 2021-01-15T04:21:38Z

@brianary Since it is a breaking change I ask PowerShell Committee to approve.

SteveL-MSFT · 2021-01-20T23:54:05Z

@PowerShell/powershell-committee reviewed this, we agreed that this is a bug that should be fixed and this is likely a bucket 3 compatibility issue.

brianary · 2021-01-24T20:12:57Z

@SteveL-MSFT should #14555 also be taken with this one, since they are so tightly related?

iSazonov · 2021-01-25T10:43:21Z

@brianary Please create new issue in PowerShell-Doc repository and add a reference to the issue in the PR description.

ghost · 2021-02-02T14:00:05Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs

iSazonov · 2021-02-03T10:49:48Z

@brianary Please rebase. I hope after that CI-Windows will pass.

…DateCommand.cs Co-authored-by: Robert Holt <[email protected]>

iSazonov · 2021-02-04T03:11:01Z

@brianary Thanks for your contribution!

ghost · 2021-02-12T02:07:40Z

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost assigned rjmholt Jan 5, 2021

iSazonov reviewed Jan 6, 2021
View reviewed changes

iSazonov mentioned this pull request Jan 6, 2021
Get-Date -UFormat inconsistencies compared to Linux strftime #4750
Closed
14 tasks

iSazonov approved these changes Jan 6, 2021
View reviewed changes

ghost added the Review - Needed The PR is being reviewed label Jan 14, 2021

iSazonov added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jan 15, 2021

ghost removed the Review - Needed The PR is being reviewed label Jan 15, 2021

SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jan 20, 2021

brianary mentioned this pull request Jan 26, 2021
Document Request: Get-Date -UFormat %u ISO8601 standard (1-7) MicrosoftDocs/PowerShell-Docs#7180
Closed

ghost added the Review - Needed The PR is being reviewed label Feb 2, 2021

rjmholt approved these changes Feb 2, 2021
View reviewed changes

src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated Show resolvedHide resolved

ghost removed the Review - Needed The PR is being reviewed label Feb 3, 2021

BrianL-STCU added 3 commits February 3, 2021 09:16

#4750Fix Get-Date -UFormat %u behavior
6594b78

Changes from PR feedback
9e0bd61

Readability change as discussed in PR
ebea063

Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Get…
c7df635
…DateCommand.cs Co-authored-by: Robert Holt <[email protected]>

iSazonov removed the Documentation Needed in this repo Documentation is needed in this repo label Feb 4, 2021

iSazonov merged commit 61fea6c into PowerShell:masterFeb 4, 2021

iSazonov added this to the 7.2.0-preview.3 milestone Feb 4, 2021

#4750 Fix Get-Date -UFormat %u behavior#14549

#4750 Fix Get-Date -UFormat %u behavior #14549

Uh oh!

Conversation

brianary commented Jan 5, 2021• edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

ghost commented Jan 5, 2021• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianary commented Jan 6, 2021

Uh oh!

Uh oh!

iSazonovJan 6, 2021

Choose a reason for hiding this comment

Uh oh!

brianaryJan 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost commented Jan 14, 2021

Uh oh!

brianary commented Jan 15, 2021

Uh oh!

iSazonov commented Jan 15, 2021

Uh oh!

SteveL-MSFT commented Jan 20, 2021

Uh oh!

brianary commented Jan 24, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Jan 25, 2021

Uh oh!

ghost commented Feb 2, 2021

Uh oh!

Uh oh!

iSazonov commented Feb 3, 2021

Uh oh!

iSazonov commented Feb 4, 2021

Uh oh!

ghost commented Feb 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brianary commented Jan 5, 2021•
edited by iSazonov
Loading

ghost commented Jan 5, 2021•
edited by ghost
Loading

brianaryJan 6, 2021•
edited
Loading

brianary commented Jan 24, 2021•
edited
Loading