Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFTSteveL-MSFT commented Jan 4, 2023

PR Summary

Per @PowerShell/wg-powershell-cmdlets review, we should have a -ProgressAction common parameter which we believe is a bucket 3 breaking change.

PR Context

Fix#18737

PR Checklist

@SteveL-MSFTSteveL-MSFT added the Breaking-Change breaking change that may affect users label Jan 4, 2023
@ghostghost assigned daxian-dbwJan 4, 2023
Copy link
Collaborator

@iSazonoviSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

…s.cs Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
@pull-request-quantifier-deprecated

This PR has 40 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label : Extra Small Size : +27 -13 Percentile : 16% Total files changed: 11 Change summary by file extension: .cs : +18 -5 .ps1 : +9 -8 

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbwdaxian-dbw merged commit 27b5a06 into PowerShell:masterJan 9, 2023
@iSazonoviSazonov added CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Jan 9, 2023
@SteveL-MSFTSteveL-MSFT deleted the progress-action branch January 9, 2023 17:50
@ghost
Copy link

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Changebreaking change that may affect usersCL-BreakingChangeIndicates that a PR should be marked as a breaking change in the Change LogCL-GeneralIndicates that a PR should be marked as a general cmdlet change in the Change LogExtra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add -ProgressAction as a common parameter

4 participants

@SteveL-MSFT@PaulHigin@iSazonov@daxian-dbw