- Notifications
You must be signed in to change notification settings - Fork 8.1k
Use interpolated strings 3#18979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use interpolated strings 3 #18979
Uh oh!
There was an error while loading. Please reload this page.
Conversation
CarloToso commented Jan 19, 2023 • edited by iSazonov
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by iSazonov
Uh oh!
There was an error while loading. Please reload this page.
....Management.Automation/SourceGenerators/PSVersionInfoGenerator/PSVersionInfoGenerator.csproj Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
iSazonov commented Jan 20, 2023
@CarloToso Please set C# 11.0 in xUnit.tests.csproj |
iSazonov commented Jan 20, 2023
@CarloToso Something wrong in the PR.... |
This PR has Quantification details
Why proper sizing of changes mattersOptimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
ghost commented Mar 14, 2023
🎉 Handy links: |
PR Summary
Replace
string.Format()with newstring.Create((IFormatProvider? provider, [InterpolatedStringHandlerArgument(nameof(provider))] ref DefaultInterpolatedStringHandler handler).PR Context
#18974
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).