[release/v7.5] Fix PSMethodInvocationConstraints.GetHashCode method#25306
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There is a difference between GetHashCode for array object itself and cumulative GetHashCode based on hashes of the array members.
microsoft-github-policy-servicebot added the Review - Needed 
TravisEz13 added CL-General 
Member
TravisEz13 commented May 14, 2025
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
| Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
TravisEz13 approved these changes May 14, 2025
TravisEz13 merged commit 2bab6df into PowerShell:release/v7.5 40 of 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24965 to release/v7.5
Triggered by @TravisEz13 on behalf of @crazyjncsu
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
Choose either tooling or Customer impact.
Tooling Impact
Customer Impact
Large amount of memory used in almost every method invocation.
Regression
7.4 - Performance regression.
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
No tests changed, because it's a perf issue not a functional issue
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]