Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

fix detection of whether `-LiteralPath` was used to suppress wildcardexpansion
Copy link
Member

@adityapatwardhanadityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan
Copy link
Member

@SteveL-MSFT The test 'Remove-Item -LiteralPath should succeed for file with asterisk in name' is failing. Please fix.

@SteveL-MSFT
Copy link
MemberAuthor

@adityapatwardhan I only ran it on my Mac, I need to skip it on Windows since asterisk isn't allowed in filename

skip -literalpath test with asterisk in filename as that's not valid on Windows
@adityapatwardhan
Copy link
Member

@SteveL-MSFT Please add the test as described in the issue #5031. That should work on Windows as well.

added more variations of tests
@SteveL-MSFT
Copy link
MemberAuthor

@adityapatwardhan added more test variations for the wildcard not finding files scenario

@adityapatwardhanadityapatwardhan merged commit ff59be3 into PowerShell:masterOct 9, 2017
@SteveL-MSFTSteveL-MSFT deleted the remove-item-wildcard branch October 9, 2017 16:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@SteveL-MSFT@adityapatwardhan