Packaging: Try to make New-Unix package more readable#5625
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TravisEz13 requested review from adityapatwardhan and daxian-dbw as code ownersTravisEz13force-pushed the macOsPackaging branch 2 times, most recently from a5071a0 to 0383540CompareTravisEz13 changed the title TravisEz13force-pushed the macOsPackaging branch 2 times, most recently from 2b7e98f to 093ab75CompareTravisEz13 changed the title 
MemberAuthor
TravisEz13 commented Dec 5, 2017
restarted appveyor due to web timeout |
adityapatwardhan approved these changes Dec 5, 2017
Member
adityapatwardhan left a comment
adityapatwardhan left a comment There was a problem hiding this comment.
LGTM with minor comments.
tools/packaging/packaging.psm1 Outdated
There was a problem hiding this comment.
Typo in dependencies, also in the comment above.
tools/packaging/packaging.psm1 Outdated
tools/packaging/packaging.psm1 Outdated
There was a problem hiding this comment.
Please add a comment for the possibilities.
tools/packaging/packaging.psm1 Outdated
tools/packaging/packaging.psm1 Outdated
MemberAuthor
There was a problem hiding this comment.
This became unreadable after changing to an array list. I filed this issue to add a feature to PowerShell so I can maintain a similar syntax and use a list:
#5643
tools/packaging/packaging.psm1 Outdated
TravisEz13force-pushed the macOsPackaging branch 3 times, most recently from d7dd323 to c48c835CompareTravisEz13force-pushed the macOsPackaging branch from c48c835 to c8492beCompareadityapatwardhan requested changes Dec 7, 2017
| throw"Dependency precheck failed!" | ||
| } | ||
| } | ||
| # Verify depenecies are installed and in the path |
| if ($AfterInstallScript){ | ||
| Remove-Item-erroraction 'silentlycontinue'$AfterInstallScript | ||
| if ($AfterScriptInfo.AfterInstallScript){ | ||
| Remove-Item-erroraction 'silentlycontinue'$AfterScriptInfo.AfterInstallScript |
| if ($AfterRemoveScript){ | ||
| Remove-Item-erroraction 'silentlycontinue'$AfterRemoveScript | ||
| if ($AfterScriptInfo.AfterRemoveScript){ | ||
| Remove-Item-erroraction 'silentlycontinue'$AfterScriptInfo.AfterRemoveScript |
MemberAuthor
There was a problem hiding this comment.
There will be a follow-up PR. I can address these issue in that PR.
Member
adityapatwardhan commented Dec 7, 2017
According to @TravisEz13 the remaining changes will be done in the next PR. |
adityapatwardhan approved these changes Dec 7, 2017
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Dec 7, 2017
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Dec 8, 2017
* refactor start-pspackage into functions * [Package] Added instrumentation * [Package] update change log * [Package] Fix distribution parameter in get-dependecies * [Package] fix dependencies * [Package] fix issues with validate script
TravisEz13 added a commit that referenced this pull request Dec 8, 2017
* refactor start-pspackage into functions * [Package] Added instrumentation * [Package] update change log * [Package] Fix distribution parameter in get-dependecies * [Package] fix dependencies * [Package] fix issues with validate script
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsPR Summary
Move large chunks of code with-in a single function out into functions to make the function easier to understand.