Skip to content

Conversation

@kilasuit
Copy link
Contributor

@kilasuitkilasuit commented May 24, 2025

PR Summary

fixes#5197

Added snippet from ISE with minor edits

  • comment help inside instead of outside the function defintion
  • added clean block and link to docs on this

Adding based on this comment on bsky

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@kilasuitkilasuit requested a review from a team as a code ownerMay 24, 2025 23:25
Copy link
Collaborator

@JustinGroteJustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godo work on the snippet, I'm not quite sure how useful this is though, maybe it should be renamed Function-Advanced-Doc-Full-Example to indicate it is an example for all the potential options? I personally would never use this, it would take me just as long to clean it up as it would to just write it naked with intellisense :)

@kilasuit
Copy link
ContributorAuthor

@JustinGrote this was a C&P from the one in ISE with very minor edits
But will take comments on board and push an update shortly

@JustinGrote
Copy link
Collaborator

I'll merge it either way, but good to make it as useful as possible yeah?

@JustinGroteJustinGrote enabled auto-merge (squash) June 1, 2025 15:22
Copy link
Collaborator

@JustinGroteJustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

JustinGrote

This comment was marked as duplicate.

@JustinGrote
Copy link
Collaborator

@andyleejordan not sure why it's waiting on codeql, I don't see it as an action...

@JustinGrote
Copy link
Collaborator

@andyleejordan bump on this.
image

@andyleejordanandyleejordan changed the title Add an extended Snippet for Advanced Functions fixes #5197Add an extended Snippet for Advanced FunctionsJul 23, 2025
Copy link
Member

@andyleejordanandyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JustinGroteJustinGrote merged commit 2093b3e into PowerShell:mainJul 23, 2025
4 checks passed
@JustinGrote
Copy link
Collaborator

Thanks @kilasuit!

@kilasuitkilasuit deleted the 5197 branch July 23, 2025 19:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an extended Snippet for Advanced Functions

3 participants

@kilasuit@JustinGrote@andyleejordan