Make tests compatible with pyftpdlib 2.0#595
Open
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Inspired by @mweinelt via #591.
pyftpdlibtest dependency from~=1.5to~=2.0pyftpdlib’stestextra (introduced in 2.0) to bring in dependencies forpyftpdlib.test, rather than naming them and maintaining their version bounds manually.ThreadedTestFTPdtoFtpdThreadWrapperI tested this locally in a Python 3.13 virtualenv, first applying #570 and #587. I do find that I can sometimes get all the tests to pass, but there are almost always some flaky failures where it seems like the test FTP server is not ready, like:
I have not tried to understand or fix that.