Catch Up Upstream#45
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Synchronized fixed
- Use `BorrowedReference` where applicable - Readd `OperatingSystemName` and `MachineName` for now
…thonnet#930) This addresses the following scenario: 1. A C# object `a` is created and filled with some data. 2. `a` is passed via Python.NET to Python. To do that Python.NET creates a wrapper object `w`, and stores reference to `a` in one of its fields. 3. Python code later passes `w` back to C#, e.g. calls `SomeCSharpMethod(w)`. 4. Python.NET has to unwrap `w`, so it reads the reference to `a` from it. Prior to this change in 4. Python.NET had to determine what kind of an object `a` is. If it is an exception, a different offset needed to be used. That check was very expensive (up to 4 calls into Python interpreter). This change replaces that check with computing offset unconditionally by subtracting a constant from the object size (which is read from the wrapper), thus avoiding calls to Python interpreter. Co-authored-by: Victor Milovanov <[email protected]>
Add a check to see if the last parameter is a params parameter. Set the correct flag to show that it is a paramsArray function. Fixespythonnet#943 and pythonnet#331.
- Add .NET Foundation - Remove Python 3.8.0 warning
Drop Python 2 support
Codecov Report
@@ Coverage Diff @@## master #45 +/- ## ========================================== - Coverage 69.42% 64.94% -4.48% ========================================== Files 1 1 Lines 278 291 +13 ========================================== - Hits 193 189 -4 - Misses 85 102 +17
Continue to review full report at Codecov.
|
Member
jaredbroad commented Jun 29, 2020
Can you please post a summary of the upgrades/fixes? |
Member
Martin-Molinero commented Mar 4, 2021
Closing in favor of #47 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase with pythonnet master.
Most important changes: