Skip to content

Conversation

@MichaelChirico
Copy link
Member

Closes#7550.

@MichaelChirico
Copy link
MemberAuthor

I also confirm we can't use URLencode() (to avoid special-casing file://)

readLines(URLencode(u)) # Error in file(con, "r") : cannot open the connection# In addition: Warning message:# In file(con, "r") :# cannot open file '/tmp/RtmpyAROdr/a%20dir/a.csv': No such file or directory

And that https? URIs will not have this issue:

https://stackoverflow.com/a/497972/3576984

I can't quite confirm the situation for ftps? URIs, but it seems like they might support spaces? I'm happy to punt until there's an actual user report, though.

@github-actions
Copy link

github-actionsbot commented Dec 29, 2025

  • HEAD=fread-file-spaces slower P<0.001 for setDT improved in #5427
    Comparison Plot

Generated via commit 62cf117

Download link for the artifact containing the test results: ↓ atime-results.zip

TaskDuration
R setup and installing dependencies2 minutes and 49 seconds
Installing different package versions1 minutes and 7 seconds
Running and plotting the test cases4 minutes and 24 seconds

@codecov
Copy link

codecovbot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.96%. Comparing base (3e579ee) to head (62cf117).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #7551 +/- ## ======================================= Coverage 98.96% 98.96% ======================================= Files 87 87 Lines 16737 16737 ======================================= Hits 16563 16563 Misses 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ben-schwenben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY!

Copy link
Member

@aitapaitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it was a bug. Thank you!

@aitapaitap merged commit 1ca9cf6 into masterJan 3, 2026
12 checks passed
@aitapaitap deleted the fread-file-spaces branch January 3, 2026 19:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.Rraw 1378.2, 1378.3 fail when the .Rcheck directory path contains spaces

3 participants

@MichaelChirico@aitap@ben-schwen