Skip to content

Conversation

@akarnokd
Copy link
Member

After reaching the prefetch limit, the updated consumed counter was not written back so the processor stopped requesting more (consumed > limit).

Affects 2.x to. A separate PR will be posted for it.

Resolves#6713

@akarnokdakarnokd added this to the 3.0 milestone Nov 14, 2019
@codecov
Copy link

codecovbot commented Nov 14, 2019

Codecov Report

Merging #6714 into 3.x will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## 3.x #6714 +/- ## ============================================ - Coverage 98.16% 98.08% -0.08%  Complexity 6191 6191 ============================================ Files 677 677 Lines 44657 44658 +1 Branches 6170 6170 ============================================ - Hits 43839 43805 -34 - Misses 293 315 +22 - Partials 525 538 +13
Impacted FilesCoverage ΔComplexity Δ
...activex/rxjava3/processors/MulticastProcessor.java98.67% <100%> (ø)84 <0> (ø)⬇️
...a3/internal/operators/flowable/FlowableCreate.java90.29% <0%> (-7.45%)6% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java92.44% <0%> (-2.91%)2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java91.57% <0%> (-2.64%)3% <0%> (ø)
...rxjava3/internal/observers/QueueDrainObserver.java97.43% <0%> (-2.57%)21% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java88.09% <0%> (-2.39%)2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java98% <0%> (-2%)3% <0%> (ø)
...tivex/rxjava3/disposables/CompositeDisposable.java98.14% <0%> (-1.86%)39% <0%> (-1%)
...ava3/internal/operators/parallel/ParallelJoin.java92.04% <0%> (-1.14%)3% <0%> (ø)
...rxjava3/internal/schedulers/ExecutorScheduler.java96% <0%> (-1%)10% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c4903...3869fc1. Read the comment docs.

@akarnokdakarnokd merged commit 5026999 into ReactiveX:3.xNov 14, 2019
@akarnokdakarnokd deleted the MulticastProcessorFix branch November 14, 2019 23:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.x: Unexpected behaviour of MulticastProcessor with buffer size larger than 1

2 participants

@akarnokd@vanniktech