Align hasCustomOnError behavior of CallbackCompletableObserver with L…#7326
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ambdaObserver, ConsumerSingleObserver and so on
Background:
CallbackCompletableObserver.hasCustomOnErrorhas a different implementation than otherLambdaConsumerIntrospectionimplementations. This causeshasCustomOnErrorto return true even if one passesFunctions.ON_ERROR_MISSINGtoCompletable.subscribe(onComplete, onError). In contrast, if one passesFunctions.ON_ERROR_MISSINGtoSingle.subscribe(onComplete, onError), the ConsumerSingleObserver returns false fromhasCustomOnError, and the case is the same withSingleforObservable,MaybeandFlowable. This makesCompletablea bit unnecessarily special.Changes made:
Use the same strategy from other observable classes.
Might be breaking:
This change is making ABI changes on
CallbackCompletableObserver. I am not sure if we need to maintain ABI stability even for classes in internal package. If it is needed, I am happy to add one more commit to keepCallbackCompletableObserver's ABI stable.