Skip to content

Conversation

@hqzxzwb
Copy link
Contributor

…ambdaObserver, ConsumerSingleObserver and so on

Background:
CallbackCompletableObserver.hasCustomOnError has a different implementation than other LambdaConsumerIntrospection implementations. This causes hasCustomOnError to return true even if one passes Functions.ON_ERROR_MISSING to Completable.subscribe(onComplete, onError). In contrast, if one passes Functions.ON_ERROR_MISSING to Single.subscribe(onComplete, onError), the ConsumerSingleObserver returns false from hasCustomOnError, and the case is the same with Single for Observable, Maybe and Flowable. This makes Completable a bit unnecessarily special.

Changes made:
Use the same strategy from other observable classes.

Might be breaking:
This change is making ABI changes on CallbackCompletableObserver. I am not sure if we need to maintain ABI stability even for classes in internal package. If it is needed, I am happy to add one more commit to keepCallbackCompletableObserver's ABI stable.

…ambdaObserver, ConsumerSingleObserver and so on
@akarnokdakarnokd added this to the 3.1-support milestone Aug 26, 2021
@codecov
Copy link

codecovbot commented Aug 26, 2021

Codecov Report

Merging #7326 (30a0d89) into 3.x (804b8ef) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## 3.x #7326 +/- ## ============================================ + Coverage 99.53% 99.55% +0.02% + Complexity 6784 6781 -3  ============================================ Files 751 751 Lines 47490 47482 -8 Branches 6378 6378 ============================================ + Hits 47269 47273 +4 + Misses 102 93 -9 + Partials 119 116 -3 
Impacted FilesCoverage Δ
...in/java/io/reactivex/rxjava3/core/Completable.java100.00% <100.00%> (ø)
...nternal/observers/CallbackCompletableObserver.java100.00% <100.00%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java93.02% <0.00%> (-4.66%)⬇️
.../operators/observable/ObservableFlatMapSingle.java94.44% <0.00%> (-3.97%)⬇️
...nternal/operators/parallel/ParallelReduceFull.java93.06% <0.00%> (-1.99%)⬇️
...operators/flowable/FlowableFlatMapCompletable.java98.71% <0.00%> (-1.29%)⬇️
...3/internal/operators/flowable/FlowablePublish.java99.00% <0.00%> (-1.00%)⬇️
...l/operators/observable/ObservableFlatMapMaybe.java91.54% <0.00%> (-0.71%)⬇️
.../reactivex/rxjava3/observers/BaseTestConsumer.java99.46% <0.00%> (-0.54%)⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java96.89% <0.00%> (-0.52%)⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804b8ef...30a0d89. Read the comment docs.

@akarnokdakarnokd mentioned this pull request Aug 26, 2021
@akarnokdakarnokd merged commit 939b5ce into ReactiveX:3.xAug 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqzxzwb@akarnokd