use AbstractOnSubscribe for StringObservable.from(InputStream) and from(Reader)#14
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
davidmotenforce-pushed the use-abstract-onsub branch from 18b6664 to 5199a24Comparedavidmotenforce-pushed the use-abstract-onsub branch from 5199a24 to 4c27713Compare
ContributorAuthor
davidmoten commented Apr 11, 2015
Moved the explicit version issue in build.gradle to #17. This PR may be ok for merge now. |
build.gradle Outdated
davidmotenforce-pushed the use-abstract-onsub branch from 4c27713 to 5ba9812CompareContributorAuthor
davidmoten commented Apr 11, 2015
woops, sorry, fixed. |
Member
akarnokd commented Apr 12, 2015
Thanks. |
akarnokd added a commit that referenced this pull request Apr 12, 2015
use AbstractOnSubscribe for StringObservable.from(InputStream) and from(Reader)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
AbstractOnSubscribeto provide much simpler implementations ofStringObservable.from(InputStream)andStringObservable.from(Reader)that support backpressure.This PR also
AbstractOnSubscribebug AbstractOnSubscribe throws exception when onNext contains a request for more RxJava#2853 is fixed)