update rx dependency to 1.1.1#36
Uh oh!
There was an error while loading. Please reload this page.
Conversation
akarnokd commented Mar 1, 2016
👍 |
| byte[] buffer = newbyte[size]; | ||
| try{ | ||
| intcount = is.read(buffer); | ||
| intcount = this.is.read(buffer); |
There was a problem hiding this comment.
This is correct but I'd prefer to see state used here instead of this.is.
jadlr commented Mar 2, 2016
@davidmoten you are right, it's much better to use the state instead of ignoring it. I added the changes. |
davidmoten commented Mar 2, 2016
👍 , thanks |
notflorian commented Mar 16, 2016
Thanks a lot for your PR! I have several applications which will use RxJava and RxJavaString to process HTTP streams on the fly, and I'd really like to be able to use the latest version of RxJava in the next release I have to do in a very near future. I've tested your PR with my applications, and everything works fine. :) @abersnaze@akarnokd : Please can you merge this PR soon and make a new release of RXJavaString? That would be very helpfull. Thanks by advance. 👍 |
zsxwing commented Mar 16, 2016
👍 |
zsxwing commented Mar 16, 2016
@notflorian thanks! |
5 participants
this fixes#33