Skip to content

Conversation

@ssung88
Copy link
Contributor

@ssung88ssung88 commented Feb 11, 2025

  • Merge when the new sdk is released

@ssung88ssung88 marked this pull request as draft February 11, 2025 20:16
@ssung88ssung88force-pushed the ssung/update_quickstart branch 3 times, most recently from a7ee794 to 403e2feCompareFebruary 11, 2025 22:20
@ssung88ssung88 changed the title Update quickstart for SDK changesUpdate quickstart guide for new PHP SDKFeb 12, 2025
@ssung88ssung88 marked this pull request as ready for review February 12, 2025 19:31
"require":{
"vlucas/phpdotenv": "^5.6"
"vlucas/phpdotenv": "^5.6",
"square/square": "^41.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only point of feedback is that for these quickstart samples I don't want to lock the version into the composer.json. I just want the README to tell the user to install the latest version of the SDK, so we don't have to keep updating this sample manually when new versions release every month.

So given that, we can merge this PR when the new SDK goes live, and the 'install latest' method will still work.

Open to dissenting thoughts on this though

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! What do you think about requiring >=41.0.0 instead? The new SDK changes start in 41, ensuring compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good, lets do that!

@ssung88ssung88force-pushed the ssung/update_quickstart branch from 403e2fe to 2b28b7dCompareFebruary 13, 2025 17:50
@ssung88ssung88 merged commit ba53b9a into mainFeb 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ssung88@mikekono@zenmasterjobo