This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Fix tests and restore #12#17
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 2daf2f8.
Member
TitleOS commented Feb 6, 2022
Building the PR fails: https://github.com/StoreDev/StoreLib/actions/runs/1802187786.
|
ContributorAuthor
rtm516 commented Feb 7, 2022
Ah no problem, I forgot to even look at the tests |
rtm516 changed the title Member
TitleOS commented Feb 7, 2022
Looks great. Everything builds and the tests pass. Thank you for correcting that issue and thank you for your contribution, merging! (hopefully for the final time heh). |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2daf2f8 back to adding thd changes in #12.
I don't understand why #12 was merged and then reverted.