Skip to content

Conversation

@itsAkshayDubey
Copy link
Contributor

@itsAkshayDubeyitsAkshayDubey commented Sep 3, 2022

Open in Gitpodknow more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

#1086

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm previously approved these changes Sep 5, 2022
@appgurueuappgurueu added the algorithm Adds or improves an algorithm label Sep 5, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you drag PrimeFactors(number) out of the expression and assign it to a variable? Also, I'd prefer it if 'Number must be greater than zero' was an error rather than a return value.

@raklaptudirmraklaptudirm changed the title Add mobius function implementationalgorithm: mobius function implementationSep 6, 2022
@raklaptudirmraklaptudirm merged commit 6f55ed4 into TheAlgorithms:masterSep 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithmAdds or improves an algorithm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@itsAkshayDubey@appgurueu@raklaptudirm