Skip to content

Conversation

@vil02
Copy link
Member

@vil02vil02 commented Feb 1, 2024

Open in Gitpodknow more

Describe your change:

This PR adds tests for SHA256.
The data was verified with https://emn178.github.io/online-tools/sha256.html.

Similar to #1602.

  • Add missing tests.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02vil02force-pushed the add_tests_for_sha256 branch from 0f5845b to dbabed8CompareFebruary 1, 2024 18:08
@vil02vil02 marked this pull request as ready for review February 1, 2024 18:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aaa376) 82.44% compared to head (dbabed8) 83.44%.

Additional details and impacted files
@@ Coverage Diff @@## master #1604 +/- ## ========================================== + Coverage 82.44% 83.44% +0.99%  ========================================== Files 377 377 Lines 19747 19747 Branches 2884 2906 +22 ========================================== + Hits 16281 16477 +196 + Misses 3466 3270 -196 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified using the sha256sum command.

@raklaptudirmraklaptudirm merged commit f313498 into TheAlgorithms:masterFeb 9, 2024
@vil02vil02 deleted the add_tests_for_sha256 branch February 9, 2024 20:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vil02@codecov-commenter@appgurueu@raklaptudirm