Skip to content

Conversation

@vil02
Copy link
Member

Open in Gitpodknow more

Describe your change:

This PR cleans-up the CoPrimeCheck:

  • the error is now thrown,

  • negative inputs are handled correctly.

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02vil02 marked this pull request as ready for review February 26, 2024 21:49
appgurueu
appgurueu previously approved these changes Feb 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (fb0a99c) to head (b5b8083).

Additional details and impacted files
@@ Coverage Diff @@## master #1609 +/- ## ========================================== + Coverage 83.62% 83.63% +0.01%  ========================================== Files 377 377 Lines 19745 19745 Branches 2910 2913 +3 ========================================== + Hits 16511 16513 +2 + Misses 3234 3232 -2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raklaptudirmraklaptudirm merged commit 0e0cf98 into TheAlgorithms:masterFeb 27, 2024
@vil02vil02 deleted the cleanup_CoPrimeCheck branch February 27, 2024 08:58
@vil02vil02 mentioned this pull request Feb 28, 2024
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vil02@codecov-commenter@appgurueu@raklaptudirm