Skip to content

Conversation

@vil02
Copy link
Member

Open in Gitpodknow more

Describe your change:

While working on #1645 I have discovered '%o'. I decided to use it here. It should have been done in #1642.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02vil02 marked this pull request as ready for review March 25, 2024 19:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (bd34e9f) to head (f49f82c).

Additional details and impacted files
@@ Coverage Diff @@## master #1646 +/- ## ======================================= Coverage 84.07% 84.07% ======================================= Files 375 375 Lines 19688 19688 Branches 2913 2913 ======================================= Hits 16552 16552 Misses 3136 3136 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02vil02 changed the title style: improve test names of GetEuclidGCD'style: improve test names of GetEuclidGCDMar 26, 2024
@raklaptudirmraklaptudirm merged commit 702840b into TheAlgorithms:masterMar 28, 2024
@vil02vil02 deleted the improve_test_names branch March 28, 2024 21:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vil02@codecov-commenter@appgurueu@raklaptudirm