Skip to content

Conversation

@cclauss
Copy link
Member

@cclausscclauss commented May 28, 2025

Fixes: #12729

As suggested at:

@MaximSmolskiy@KirilBangachev@skirpichev Careful review, please. I am just implementing the suggestion, but I do not have any expertise in this area.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

As suggested at: * #12729 (comment) * #12710 (comment)@MaximSmolskiy@KirilBangachev@skirpichev Careful review, please. I am just implementing the suggestion, but I do not have any expertise in this area.
@algorithms-keeperalgorithms-keeperbot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels May 28, 2025
@algorithms-keeperalgorithms-keeperbot removed tests are failing Do not merge until tests pass labels May 28, 2025
It is confusing to have two jobs named `build`.
on: [push]
jobs:
build:
directory_writer:
Copy link
MemberAuthor

@cclausscclaussMay 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is too confusing to have two GitHub Actions jobs named build, so rename this job to document what it really does.

Copy link
Member

@MaximSmolskiyMaximSmolskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a basic knowledge of complex numbers from university course. For me, the changes are equivalent. So, the difference lies somewhere deep in the subtleties of practical implementation, which I don't know at all

@cclauss
Copy link
MemberAuthor

Nice teamwork on this one. Thanks much!

@cclausscclauss merged commit d0d7f0b into masterMay 29, 2025
6 checks passed
@cclausscclauss deleted the maths/radix2_fft.py-on-Python-3.14 branch May 29, 2025 06:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewsThis PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help wanted: Why do maths/radix2_fft.py test results change on Python 3.14 beta?

4 participants

@cclauss@skirpichev@MaximSmolskiy