Skip to content

added rotate_array.py#13336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cclauss merged 14 commits into from
Oct 8, 2025
Merged

added rotate_array.py #13336

cclauss merged 14 commits into from
Oct 8, 2025

Conversation

@jenyyy4
Copy link
Contributor

@jenyyy4jenyyy4 commented Oct 7, 2025

Description:

This PR adds a utility function rotate_array which rotates a given list by k positions. It handles both positive and negative rotation values, as well as cases where k is larger than the length of the array.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperbot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 7, 2025
algorithms-keeper[bot]
algorithms-keeperbot reviewed Oct 7, 2025
View reviewed changes
Copy link

@algorithms-keeperalgorithms-keeperbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/arrays/rotate_array.py Outdated
@@ -0,0 +1,34 @@
def rotate_array(arr, k):
Copy link

@algorithms-keeperalgorithms-keeperbotOct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: rotate_array. If the function does not return a value, please provide the type hint as:def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/rotate_array.py, please provide doctest for the function rotate_array

Please provide type hint for the parameter: arr

Please provide type hint for the parameter: k

Please provide descriptive name for the parameter: k

@algorithms-keeperalgorithms-keeperbot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2025
algorithms-keeper[bot]
algorithms-keeperbot reviewed Oct 7, 2025
View reviewed changes
Copy link

@algorithms-keeperalgorithms-keeperbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeperalgorithms-keeperbot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 7, 2025
algorithms-keeper[bot]
algorithms-keeperbot reviewed Oct 7, 2025
View reviewed changes
Copy link

@algorithms-keeperalgorithms-keeperbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/arrays/rotate_array.py
if k < 0:
k += n

def reverse(start: int, end: int) -> None:
Copy link

@algorithms-keeperalgorithms-keeperbotOct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/rotate_array.py, please provide doctest for the function reverse

@algorithms-keeperalgorithms-keeperbot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 7, 2025
algorithms-keeper[bot]
algorithms-keeperbot reviewed Oct 7, 2025
View reviewed changes
Copy link

@algorithms-keeperalgorithms-keeperbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/arrays/rotate_array.py Outdated
from typing import List


def rotate_array(arr: List[int], k: int) -> List[int]:
Copy link

@algorithms-keeperalgorithms-keeperbotOct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: k

Copy link
Member

@cclausscclaussOct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single-letter variable names are uncool, as discussed in CONTRIBUTING.md.

@algorithms-keeperalgorithms-keeperbot added tests are failing Do not merge until tests pass and removed require descriptive names This PR needs descriptive function and/or variable names labels Oct 7, 2025
@jenyyy4
Copy link
ContributorAuthor

jenyyy4 commented Oct 8, 2025

@cclauss hey could you look into this? and see why there's an issue?

@cclauss
Copy link
Member

cclauss commented Oct 8, 2025

https://docs.astral.sh/ruff/rules/non-pep585-annotation/

@TheAlgorithmsTheAlgorithms deleted a comment from sgpohlj87Oct 8, 2025
@algorithms-keeperalgorithms-keeperbot removed the tests are failing Do not merge until tests pass label Oct 8, 2025
@jenyyy4
Copy link
ContributorAuthor

jenyyy4 commented Oct 8, 2025

@cclauss i have fixed what i needed to fix, now 1 check was skipped. Could you review this? And if everything is good to go, can you merge this pr?

@algorithms-keeperalgorithms-keeperbot removed the awaiting reviews This PR is ready to be reviewed label Oct 8, 2025
@cclausscclauss merged commit 788d95b into TheAlgorithms:masterOct 8, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jenyyy4@cclauss