Skip to content

Conversation

@abhijitgawai
Copy link

@abhijitgawaiabhijitgawai commented Oct 3, 2021

Many people ignore it. Please add this invalid case where input is worng (when length of weight and value is not equal)

Describe your change:

There is invalid case in knapsack. Many people ignore it. I have included that case in knapsack.py
Invalid case is a case where weight and value array is not of equal length

Therefore I added - if len(wights)!=len(values): return -1

I have returned -1 because otherwise user will not get to know that input was wrong.
If I would have returned 0, user would think, there is no space in bag to accept least weight.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghostghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 3, 2021
@cclausscclauss closed this Oct 11, 2021
@ghostghost removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2021
@abhijitgawaiabhijitgawai mentioned this pull request Oct 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing filesinvalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@abhijitgawai@cclauss