Skip to content

Conversation

@marci4
Copy link
Collaborator

Description

No not use the Outputstream to detect exceptions.

Related Issue

#877

Motivation and Context

Shitty test

How Has This Been Tested?

Locally run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

No not use the Outputstream to detect exceptions.
@marci4marci4 mentioned this pull request Apr 14, 2019
4 tasks
@marci4marci4 added this to the Release 1.4.1 milestone Apr 16, 2019
@marci4marci4 merged commit 8a74a87 into TooTallNate:masterApr 22, 2019
@marci4marci4 removed the Bug label Mar 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@marci4@ItsHarper